Remove the $$scope key from $$props when calculating spread #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilTholin
changed the title
|
that is a nice fix |
|
I'm still getting this exact error.
Now, $$slots and $$scope are found in passProps and give the following error when passProps is passed to a component:
If I try and remove these from passProps like so, I get an error saying $ is reserved and cannot be used for import names;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes is so the
$$scopeproperty of the$$propsobject will not be included in a spread update to avoid errors likeDOMException: Failed to execute 'setAttribute' on 'Element': '$$scope' is not a valid attribute name.By setting
$$scopeas accounted for straight away inget_spread_updateit will not be part of the update.Fixes #2520